Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Mode Switcher and nit fixes #1962

Merged
merged 12 commits into from
May 15, 2024
Merged

Color Mode Switcher and nit fixes #1962

merged 12 commits into from
May 15, 2024

Conversation

insectengine
Copy link
Collaborator

@insectengine insectengine commented Apr 22, 2024 •
edited
Loading

resolves #1809

Builds upon @holly-cummins 's work in PR 1954

  1. Added color mode switcher in navigation (that changes to show state: light, dark, system).
  2. Fixed pre code color issue in darkmode
  3. Added solution for images in blog/guides with transparency in dark mode.

Outstanding issue: Still need Guides index fix for icons in dark mode

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@insectengine
Copy link
Collaborator Author

Removing PR to fix a significant error.

@insectengine insectengine reopened this Apr 24, 2024
@insectengine insectengine deleted the Mode_updates branch April 25, 2024 13:21
@insectengine insectengine restored the Mode_updates branch April 25, 2024 13:24
@insectengine insectengine reopened this Apr 25, 2024
gsmet
gsmet requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look: seems to work fine.

I have one small gripe though: the avatar pictures shouldn't have a padding or it makes them really weird.

See https://quarkus-site-pr-1962-preview.surge.sh/blog/search-indexing-rollover/ for instance.

@insectengine
Copy link
Collaborator Author

@gsmet - Fixed the gravatar images

@insectengine insectengine requested a review from gsmet May 1, 2024 15:35
@insectengine insectengine mentioned this pull request May 6, 2024
Closed
@holly-cummins holly-cummins mentioned this pull request May 14, 2024
Merged
@insectengine
Copy link
Collaborator Author

@gsmet - I'm not sure what I need to do next to move this forward. I've committed the changes you requested.

insectengine
insectengine commented May 15, 2024
View reviewed changes
Copy link
Collaborator Author

@insectengine insectengine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes addresses your comment

gsmet
gsmet approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's merge it and gather feedback from the field.

Thanks for your patience!

@gsmet gsmet merged commit 8fbf473 into quarkusio:develop May 15, 2024
1 check passed
@gsmet
Copy link
Member

gsmet commented May 15, 2024 •
edited
Loading

@insectengine sorry I was on PTO and juggling with priorities since I got back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Quarkus Docs page with Dark mode
2 participants
@insectengine @gsmet